Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-dialog duplicating IDs #6339

Closed
jayanezj opened this issue Dec 16, 2015 · 1 comment
Closed

md-dialog duplicating IDs #6339

jayanezj opened this issue Dec 16, 2015 · 1 comment
Assignees
@ThomasBurleson

Comments

@jayanezj
Copy link

Consider this CodePen:

http://codepen.io/berikin/pen/gPPzRK

When the md-dialog is created, his child md-dialog-content receives the same id of the parent.

Duplicated id

Even if we force a different id for md-dialog-content, as seen in this CodePen:

http://codepen.io/berikin/pen/JGGvyE
@ThomasBurleson ThomasBurleson self-assigned this Jan 5, 2016
@ThomasBurleson ThomasBurleson modified the milestone: Backlog Jan 5, 2016
devversion added a commit to devversion/material that referenced this issue Jan 16, 2016
@devversion
fix(dialog): prevent duplicate ids for md-dialog and md-dialog-content
6ff414a 
I thought about the current version, there we always have two times the same id, and not desired.
That's why I prefixed the id, so the user can still access the md-dialog-content through id.

Fixes angular#6339
@devversion
Copy link
Member

Yes that seems to be an issue. The problem is caused here.
And this line makes no sense, because this will always cause duplicate id (if specified)

@devversion devversion mentioned this issue Jan 16, 2016
Closed
devversion added a commit to devversion/material that referenced this issue Jan 30, 2016
@devversion
fix(dialog): prevent duplicate ids for md-dialog and md-dialog-content
ad6bbb0 
I thought about the current version, there we always have two times the same id, and not desired.
That's why I prefixed the id, so the user can still access the md-dialog-content through id.

Fixes angular#6339
devversion added a commit to devversion/material that referenced this issue Jan 31, 2016
@devversion
fix(dialog): prevent duplicate ids for md-dialog and md-dialog-content
e13e969 
I thought about the current version, there we always have two times the same id, and not desired.
That's why I prefixed the id, so the user can still access the md-dialog-content through id.

Fixes angular#6339
ErinCoughlan pushed a commit to ErinCoughlan/material that referenced this issue Feb 9, 2016
@devversion @ErinCoughlan
fix(dialog): prevent duplicate ids for md-dialog and md-dialog-content
5e6e5b1 
Fixes angular#6339, Closes angular#6717.
@Splaktar Splaktar removed this from the - Backlog milestone Feb 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ThomasBurleson ThomasBurleson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(dialog): prevent duplicate ids for md-dialog and md-dialog-content devversion/material
4 participants
@ThomasBurleson @jayanezj @Splaktar @devversion