Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Allow chaining on fontSet method #3238

Closed
wants to merge 1 commit into from
Closed

Conversation

shprink
Copy link
Contributor

@shprink shprink commented Jun 11, 2015

Codepen: http://codepen.io/shprink/pen/LVLmYm

Open the console.

 $mdIconProvider
            .fontSet('fa', 'fontawesome')
            .defaultFontSet('fontawesome');

Does not work.

Review on Reviewable

Codepen: http://codepen.io/shprink/pen/LVLmYm

Open the console.

```
 $mdIconProvider
            .fontSet('fa', 'fontawesome')
            .defaultFontSet('fontawesome');
```

Does not work.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@shprink
Copy link
Contributor Author

shprink commented Jun 11, 2015

I signed it!

On Thu, Jun 11, 2015 at 5:11 PM, googlebot notifications@github.com wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project, in which case you'll need to
sign a Contributor License Agreement (CLA).

[image: 📝] Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.


Reply to this email directly or view it on GitHub
#3238 (comment).

@googlebot
Copy link

CLAs look good, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants