This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
chore(tests): remove ddescribe() #3626
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
referenced
this pull request
Jul 7, 2015
* fixes ability to use ng-hide: the animations were not properly calling the `done()` callback, so the `ng-animate` class was never being removed * you can now use ng-repeat for the speed dial's action items also updated docs to have fewer but more complex examples * the speed dial was not properly initializing it's transforms, so the first time it was opened, it would not animate properly closes #3313. closes #3224. closes #3349. closes #3600.
|
@gkalpak there are some failing tests though, that's not very good. Are you an owner/collaborator on this repo? We should get this reviewed and landed to prevent similar mistakes in the future |
Prevent ddescribe()/iit() from sneaking in again
|
I just committed fixes to remove the |
|
I saw. There's a second (now only) commit in this CL which adds a check for ddescribe/iit to prevent it from sneaking in in the future |
|
@caitp - I like these changes. THANK you!
I will merge now! |
|
@caitp - this addition rocks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was preventing tests from running, oops!