This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(select): interimElement will resolve its promise even when #3794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
transition end event is not fired Closes #3704
|
@ThomasBurleson Wanted you to look over this before merging in. |
|
@ThomasBurleson I may spend some time over the weekend looking into a more proper fix for this, so we should probably hold off until Monday to merge it - but it should be fine to merge either way. |
|
This looks good (and in hindsight so obvious). Now:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transition end event is not fired
Closes #3704