This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(dialog): removed no dialog actions warning #5774
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EladBezalel
force-pushed
the
fix/dialog-removed-warn-no-actions
branch
2 times, most recently
from
5faa591
to
d73cd30
Compare
|
LGTM |
jelbourn
added
pr: merge ready
EladBezalel
force-pushed
the
fix/dialog-removed-warn-no-actions
branch
from
d73cd30
to
c2d36c4
Compare
It is a valid use-case to have a dialog that you only close programmatically based on some user action. As such, there shouldn't be a warning when there are no md-dialog-actions present. fixes #5767
EladBezalel
force-pushed
the
fix/dialog-removed-warn-no-actions
branch
from
c2d36c4
to
17a07a2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a valid use-case to have a dialog that you only close programmatically based on some user action. As such, there shouldn't be a warning when there are no md-dialog-actions present.
fixes #5767