This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(list): fix list margin if anchor is present. #6496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
EladBezalel
added
the
needs: manual testing
|
@devversion can you address me what should i do to test this manually ? |
|
I don't think there is something to test, you should just take a look to the list-items, one applied with ng-href and one applied with ng-click |
devversion
force-pushed
the
fix/list-anchor-margin
branch
2 times, most recently
from
d9d44fc
to
e704eed
Compare
EladBezalel
added
pr: merge ready
If there is currently a `md-button` anchor, we should remove the margin to order the items as the other items. Fixes angular#5608 Fixes angular#6317
devversion
force-pushed
the
fix/list-anchor-margin
branch
from
e704eed
to
bfa702e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is currently a
md-buttonanchor, we should remove the margin to order the items as the other items.Fixes #5608 Fixes #6317