This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(docs): stretched icon button will interfere with ripple #7227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As there is the icon button in the toolbar currently stretched, the ripple isn't working anymore. This can be fixed by removing that stretching. - Everything will work still the same, except the button won't be moved `8px` right (but that still looks fine) Line introduced in angular@bd9bbdb#diff-272b77251b74dd4fbf020ac40c529c11R396
ThomasBurleson
added
pr: merge ready
ThomasBurleson
pushed a commit
that referenced
this pull request
Feb 26, 2016
As there is the icon button in the toolbar currently stretched, the ripple isn't working anymore. This can be fixed by removing that stretching. - Everything will work still the same, except the button won't be moved `8px` right (but that still looks fine) Line introduced in bd9bbdb#diff-272b77251b74dd4fbf020ac40c529c11R396 Closes #7227
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As there is the icon button in the toolbar currently stretched, the ripple isn't working anymore.
This can be fixed by removing that stretching.
8pxright (but that still looks fine)Line introduced in bd9bbdb#diff-272b77251b74dd4fbf020ac40c529c11R396
@robertmesserle Can you remember why you added this line?