Skip to content

Commit

Permalink
feat(misc-pages): responsive for canceled game and not found game pag…
Browse files Browse the repository at this point in the history
…es (#888)

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Improved layout and styling for the Game Canceled and Game Not Found
pages, enhancing user experience.
- Responsive design adjustments for buttons, ensuring better usability
across mobile and desktop devices.
- Enhanced visual presentation of error messages with centered text and
improved font sizes.

- **Bug Fixes**
- Resolved alignment and spacing issues for buttons and text in various
components.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
antoinezanardi authored Sep 18, 2024
1 parent 02e728a commit deeb7b2
Show file tree
Hide file tree
Showing 13 changed files with 71,235 additions and 71,179 deletions.
10 changes: 5 additions & 5 deletions app/components/pages/game/GameCanceled/GameCanceled.vue
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<template>
<div
id="game-canceled"
class="flex flex-col items-center justify-center"
class="flex flex-col gap-2 items-center justify-center"
>
<h1
id="game-canceled-text"
Expand All @@ -17,12 +17,12 @@
</span>
</h1>

<div>
<PrimeVueDivider class="mb-4"/>
<PrimeVueDivider class="!w-2/3"/>

<CreateAnotherGameButton/>
<div class="flex flex-col gap-2 md:flex-row">
<CreateAnotherGameButton class="md:w-auto w-full"/>

<BackToHomeButton/>
<BackToHomeButton class="md:w-auto w-full"/>
</div>
</div>
</template>
Expand Down
12 changes: 6 additions & 6 deletions app/components/pages/game/GameNotFound/GameNotFound.vue
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<template>
<div
id="game-not-found"
class="flex flex-col items-center justify-center"
class="flex flex-col gap-2 items-center justify-center"
>
<h1
id="game-not-found-text"
Expand All @@ -12,17 +12,17 @@
icon="fa-regular fa-question-circle"
/>

<span>
<span class="text-center">
{{ $t("components.GameNotFound.gameNotFound") }}
</span>
</h1>

<div>
<PrimeVueDivider class="mb-4"/>
<PrimeVueDivider class="!w-2/3"/>

<CreateAnotherGameButton class="me-2"/>
<div class="flex flex-col gap-2 md:flex-row">
<CreateAnotherGameButton class="md:w-auto w-full"/>

<BackToHomeButton/>
<BackToHomeButton class="md:w-auto w-full"/>
</div>
</div>
</template>
Expand Down
4 changes: 2 additions & 2 deletions app/error.vue
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
>
<h1
id="error-title"
class="!text-5xl"
class="!text-5xl text-center"
>
{{ errorTitle }}
</h1>
Expand All @@ -20,7 +20,7 @@

<h3
id="error-description"
class="!text-2xl"
class="md:!text-2xl text-center text-xl"
>
{{ errorDescription }}
</h3>
Expand Down
Binary file modified tests/acceptance/screenshots/darwin/Game canceled.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/acceptance/screenshots/darwin/Game not found.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/acceptance/screenshots/linux/Game canceled.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/acceptance/screenshots/linux/Game not found.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading

0 comments on commit deeb7b2

Please sign in to comment.