Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pwa): remove redirect fallback #830

Merged
merged 1 commit into from
Sep 8, 2024
Merged

fix(pwa): remove redirect fallback #830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions nuxt.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,10 +172,11 @@ export default defineNuxtConfig({
periodicSyncForUpdates: 86400,
},
workbox: {
globPatterns: ["**/*.{js,css,html,png,svg,ico}"],
globPatterns: ["**/*.{js,css,html,png,svg,ico,json,woff2}"],
navigateFallbackDenylist: [/^.*$/u],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential Over-restriction by navigateFallbackDenylist

The regex /^.*$/u used in navigateFallbackDenylist blocks all navigation fallbacks. This might be too restrictive and could potentially break navigation for URLs that should be handled by the service worker. Consider specifying a more targeted regex to exclude only the intended URLs.

},
injectManifest: {
globPatterns: ["**/*.{js,css,html,png,svg,ico}"],
globPatterns: ["**/*.{js,css,html,png,svg,ico,json,woff2}"],
},
manifest: {
name: process.env.NUXT_SITE_NAME,
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"start:prod": "node .output/server/index.mjs",
"prepare": "is-ci || husky",
"build": "nuxt build",
"dev": "nuxt dev --dotenv env/.env.development",
"dev": "nuxt dev --dotenv env/.env.development --port 4000",
"generate": "nuxt generate",
"preview": "npm run build && nuxt preview --dotenv env/.env.production",
"postinstall": "! ls -log -u node_modules/.bin/nuxt || nuxt prepare",
Expand Down
46 changes: 0 additions & 46 deletions public/favicons/site.webmanifest
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion ...ptance/features/game-lobby/features/game-lobby-options-hub/game-lobby-options-hub.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ Feature: ⚙️ Game Lobby Options Hub
And the user disables the sheriff in game options

When the user reloads the page
And the user clicks on the link with name "Play"
And the user clicks on the game options button in the lobby
Then the heading with name "Game options" should be visible
And the exact text "The game will not have a Sheriff." should be visible
Expand Down
Loading