Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RM Update abbreviations.rst #3393

Merged
merged 2 commits into from
Aug 8, 2023
Merged

RM Update abbreviations.rst #3393

merged 2 commits into from
Aug 8, 2023

Conversation

walterkozlowski
Copy link
Collaborator

Added missing abbreviations:
AF_XDP, eBPF, SSDF, XDP, ZAP, ZTA

Added missing abbreviations: 
AF_XDP, eBPF, SSDF, XDP, ZAP, ZTA
@walterkozlowski walterkozlowski self-assigned this Aug 8, 2023
@walterkozlowski walterkozlowski added GSMA minor Pull request suggesting minor/editorial changes labels Aug 8, 2023
@@ -98,6 +99,7 @@ DSP Digital Signal Processor
DU Distributed Unit (O-RAN context)
DVR Distributed Virtual Routing
E2E End to End
EBPF Extended Berkley Packet Filter
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually this is written with a small "e" like eBPF. I'm not sure if this should be followed here...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, as per the PR description. My fault, corrected.

corrected to eBPF
Copy link
Collaborator

@CsatariGergely CsatariGergely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh-oh, there are some broken links again.

( common/glossary: line 124) broken https://www.itu.int/rec/dologin_pub.asp?lang=e&id=T-REC-Y.3500-201408-I!!PDF-E&type=items - 500 Server Error: Internal Server Error for url: https://www.itu.int/rec/dologin_pub.asp?lang=e&id=T-REC-Y.3500-201408-I!!PDF-E&type=items

@CsatariGergely
Copy link
Collaborator

Uh-oh, there are some broken links again.

( common/glossary: line 124) broken https://www.itu.int/rec/dologin_pub.asp?lang=e&id=T-REC-Y.3500-201408-I!!PDF-E&type=items - 500 Server Error: Internal Server Error for url: https://www.itu.int/rec/dologin_pub.asp?lang=e&id=T-REC-Y.3500-201408-I!!PDF-E&type=items

I suggest to fix these first in a separate PR and approve this with a green build. I can create the fixing PR.

@CsatariGergely
Copy link
Collaborator

Uh-oh, there are some broken links again.
( common/glossary: line 124) broken https://www.itu.int/rec/dologin_pub.asp?lang=e&id=T-REC-Y.3500-201408-I!!PDF-E&type=items - 500 Server Error: Internal Server Error for url: https://www.itu.int/rec/dologin_pub.asp?lang=e&id=T-REC-Y.3500-201408-I!!PDF-E&type=items

I suggest to fix these first in a separate PR and approve this with a green build. I can create the fixing PR.

#3397 contains the fix.

@walterkozlowski
Copy link
Collaborator Author

walterkozlowski commented Aug 8, 2023

@CsatariGergely, shouldn't it work now after #3397 has been merged?
@CsatariGergely Can you please re-review and approve?

@CsatariGergely
Copy link
Collaborator

@CsatariGergely, shouldn't it work now after #3397 has been merged? @CsatariGergely Can you please re-review and approve?

Yep. I just needed to re-trigger the build. All green now, good to go!

@walterkozlowski
Copy link
Collaborator Author

@rgstori, looks like one of the code owners need to approve and I cannot do this as I initiated this pr. Can you have a look and approve if you can?

@rgstori rgstori merged commit 23a5c40 into master Aug 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSMA minor Pull request suggesting minor/editorial changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants