allow zoom in just one direction as an option #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needed a left to right zoom as an option Altered this code to make that happen
option for both x and y when the aspect ration link is broken
found a bug
Recent code changes misused animate.
Pass {x : value, y : value} for 2D scaling. animate will use scale or (x,y). Fields subjected to difference are at the top level.
Global scaling options (new option) was not being applied to zoom. Fixed. Fixed also, cases where zero scaling means don't scale but scaling is used as a multiplier of scale while some times it eliminates translation at scale for translation being shut down in one direction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created an option preserveAspectRatio, which is a Boolean.
By default this is true. When true, it runs original code.
If it is false, then scaleFactors may be set as an option. These are
{ x : <number>, y : <number> }.If either its x or y is zero, then the scale of the transform is always one in the chosen direction. Otherwise, the x or y value is a multiplier of scale, which is also broken up into scaleX and scaleY.
Did this by branching code on preserveAspectRatio which internally is being tracked by linkAspect, a Boolean value.
In this commit, only the SVG version is affected. Scaling still means object size changes. The aim is to watch them grow apart as a priority. { There may be cases when the object size (thickness in particular) may stay the same. This is not addressed. }
Needed this for a time line. The application needs to have boxes drawn from start times to stop times (short/long spans).