Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

chore: Adaptation of storybook 6.x params #1414

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

stephenLYZ
Copy link
Contributor

🐛 Bug Fix
Fix the problem that the chart's width and height of storybook 6 cannot be correctly adapted.

image

after

2021-10-20.3.42.18.mov

@stephenLYZ stephenLYZ requested a review from a team as a code owner October 20, 2021 07:44
@vercel
Copy link

vercel bot commented Oct 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/58ZbLaBHpQwpy4tcxUjzw1Uibfnb
✅ Preview: https://superset-ui-git-fork-stephenlyz-fix-storybook-6-superset.vercel.app

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #1414 (10e0262) into master (86fd95c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1414   +/-   ##
=======================================
  Coverage   30.41%   30.41%           
=======================================
  Files         497      497           
  Lines        9996     9996           
  Branches     1687     1687           
=======================================
  Hits         3040     3040           
  Misses       6710     6710           
  Partials      246      246           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86fd95c...10e0262. Read the comment docs.

Copy link
Contributor

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@zhaoyongjie zhaoyongjie merged commit 746d399 into apache-superset:master Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants