Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat(chart-controls): add time grain control to all charts #1469

Closed

Conversation

kgabryje
Copy link
Contributor

This PR adds time grain control to every chart that has time section.

@kgabryje kgabryje requested a review from a team as a code owner November 12, 2021 15:53
@vercel
Copy link

vercel bot commented Nov 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/6CGmwy7NacQHK9qyp7MU8mm4aJMe
✅ Preview: https://superset-ui-git-fork-kgabryje-feat-time-grain-a-b53920-superset.vercel.app

Copy link
Contributor

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro
Copy link
Contributor

The codebase on this repo has been moved to the main Apache Superset repo, and consequently the repo is in the process of being archived. See the Superset Improvement Proposal for details: apache/superset#13013 . While all currently open issues and PRs will be closed, we encourage you to reopen this PR on the main repo, which should be as simple as moving over any code changes as follows:

  • core packages: packages/** (this repo) -> superset-frontend/packages/** (main repo)
  • plugins: plugins/** (this repo) -> superset-frontend/plugins/** (main repo)

If you need help with the migration, please post a message on the SIP or reach out on the community Slack.

@villebro villebro closed this Dec 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants