Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-3023: Test against Ruby 3.0 #1048

Merged
merged 3 commits into from
Jan 31, 2021
Merged

Conversation

tjwp
Copy link
Contributor

@tjwp tjwp commented Jan 10, 2021

AVRO-3023: Test against Ruby 3.0.

Ruby 3.0 was released 12/25/2020: announcement

actions/setup-ruby has not been updated to support Ruby 3.0. Based on this issue, it looks like ruby/setup-ruby will be preferred and we should switch to it. That action also has built-in support for dependency caching. We should consider trying that instead of actions/cache but I have not done that here in order to keep this change minimal.

@github-actions github-actions bot added the build label Jan 10, 2021
@github-actions github-actions bot added the Ruby label Jan 10, 2021
@tjwp tjwp requested a review from kojiromike January 10, 2021 13:54
steps:
- uses: actions/checkout@v2

- uses: actions/setup-ruby@v1
- uses: ruby/setup-ruby@v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need infra- approval to run actions that aren't official. Do you know if this one's approved?

See https://issues.apache.org/jira/browse/INFRA-21253 for example.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the build was able to use ruby/setup-ruby successfully, does that mean that it was already approved?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the build was able to use ruby/setup-ruby successfully, does that mean that it was already approved?

No, I don't believe it does. IIUC this build ran on your fork in your account, which isn't restricted by Apache rules.

But since you got the official approval from infra we are good to go.

@kojiromike kojiromike merged commit 8da4321 into apache:master Jan 31, 2021
@tjwp tjwp deleted the tjwp-ruby-3.0 branch February 1, 2021 12:28
RyanSkraba pushed a commit to RyanSkraba/avro that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants