Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental annotation from Beam #26490

Merged
merged 1 commit into from
May 9, 2023

Conversation

kennknowles
Copy link
Member

Drop @experimental annotations and concept from Beam. Discussion occurred at https://lists.apache.org/thread/tvvdckdom8jtv2xr9mzg0ltjjpbmydrv.

Largely automated change. There are likely mentions in comments and elsewhere that will have follow-up changes to clean up the conceptual framework.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@kennknowles kennknowles force-pushed the delete-experimental branch 2 times, most recently from 199b2a0 to 90a1e02 Compare May 3, 2023 18:10
@kennknowles
Copy link
Member Author

run java precommit

@kennknowles
Copy link
Member Author

Java_Spark3_Versions failed with gradle executor dying

@kennknowles
Copy link
Member Author

Run Java_Spark3_Versions PreCommit

@kennknowles
Copy link
Member Author

Cassandra and SQL+Java17 actually were hung jobs

@kennknowles
Copy link
Member Author

Run SQL_Java17 PreCommit

@kennknowles
Copy link
Member Author

Run Java_Cassandra_IO_Direct PreCommit

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@kennknowles
Copy link
Member Author

Resolved conflicts and pushed. So all the tests need to re-run anyhow. The problem was a known timeout in the GitHub Actions workflows. We will see if we can get it green.

@brucearctor
Copy link
Contributor

The problem was a known timeout in the GitHub Actions workflows. We will see if we can get it green.

The "known timeout" ... is this something we have some ability to do anything about. Ex: if we run some 'self-hosted' runners [ https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners/about-self-hosted-runners ]? I don't know enough about the issue. Happy to help configure things, sort out a solution, assuming there is some good docs on the known issue and we believe there might be a solution.

@kennknowles
Copy link
Member Author

Run Java_IOs_Direct PreCommit

@kennknowles
Copy link
Member Author

RabbitMQ failed to come up for the tests. I'll check if it fails again.

@kennknowles
Copy link
Member Author

@kennknowles
Copy link
Member Author

@darshan-sj saw the above failure in Spanner databoost and I noticed you authored #26007

@kennknowles
Copy link
Member Author

Run Java_GCP_IO_Direct PreCommit

@kennknowles
Copy link
Member Author

Run Java_GCP_IO_Direct PreCommit

@kennknowles
Copy link
Member Author

@kennknowles
Copy link
Member Author

Run Java_GCP_IO_Direct PreCommit

@kennknowles
Copy link
Member Author

I think we've kicked the flakes enough times here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment