-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove experimental annotation from Beam #26490
Conversation
199b2a0
to
90a1e02
Compare
90a1e02
to
002acd4
Compare
run java precommit |
Java_Spark3_Versions failed with gradle executor dying |
Run Java_Spark3_Versions PreCommit |
Cassandra and SQL+Java17 actually were hung jobs |
Run SQL_Java17 PreCommit |
Run Java_Cassandra_IO_Direct PreCommit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
002acd4
to
459e166
Compare
Resolved conflicts and pushed. So all the tests need to re-run anyhow. The problem was a known timeout in the GitHub Actions workflows. We will see if we can get it green. |
The "known timeout" ... is this something we have some ability to do anything about. Ex: if we run some 'self-hosted' runners [ https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners/about-self-hosted-runners ]? I don't know enough about the issue. Happy to help configure things, sort out a solution, assuming there is some good docs on the known issue and we believe there might be a solution. |
Run Java_IOs_Direct PreCommit |
RabbitMQ failed to come up for the tests. I'll check if it fails again. |
@darshan-sj saw the above failure in Spanner databoost and I noticed you authored #26007 |
Run Java_GCP_IO_Direct PreCommit |
Run Java_GCP_IO_Direct PreCommit |
Run Java_GCP_IO_Direct PreCommit |
I think we've kicked the flakes enough times here. |
Drop @experimental annotations and concept from Beam. Discussion occurred at https://lists.apache.org/thread/tvvdckdom8jtv2xr9mzg0ltjjpbmydrv.
Largely automated change. There are likely mentions in comments and elsewhere that will have follow-up changes to clean up the conceptual framework.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.