Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable cache compression #27023

Merged
merged 8 commits into from
Jun 7, 2023
Merged

Disable cache compression #27023

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5e84f42
Disable cache compression
davidcavazos Jun 5, 2023
d7b2426
Update CHANGES.md
davidcavazos Jun 5, 2023
c236b49
Fix line too long linter issue
davidcavazos Jun 5, 2023
8e84ece
Update CHANGES.md
davidcavazos Jun 6, 2023
eb357fe
Disable pip cache directory
davidcavazos Jun 6, 2023
3170c25
Update CHANGES.md
davidcavazos Jun 6, 2023
5fe72f1
revert reducing image size
davidcavazos Jun 6, 2023
3c3095c
Merge branch 'master' of github.com:apache/beam into patch-1
davidcavazos Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@

## New Features / Improvements

* Allow prebuilding large images when using `--prebuild_sdk_container_engine=cloud_build`, like images depending on `tensorflow` or `torch` ([#27023](https://github.com/apache/beam/pull/27023))
* X feature added (Java/Python) ([#X](https://github.com/apache/beam/issues/X)).

## Breaking Changes
Expand Down
8 changes: 7 additions & 1 deletion sdks/python/apache_beam/runners/portability/sdk_container_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,13 @@ def _invoke_docker_build_and_push(self, container_image_name):
build.steps = []
step = cloudbuild.BuildStep()
step.name = 'gcr.io/kaniko-project/executor:latest'
step.args = ['--destination=' + container_image_name, '--cache=true']
# Disable compression caching to allow for large images to be cached.
# See: https://github.com/GoogleContainerTools/kaniko/issues/1669
step.args = [
'--destination=' + container_image_name,
'--cache=true',
'--compressed-caching=false',
davidcavazos marked this conversation as resolved.
Show resolved Hide resolved
]
step.dir = SOURCE_FOLDER

build.steps.append(step)
Expand Down