Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#24789] Missed prism defaults and programming guide changes #27832

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

lostluck
Copy link
Contributor

@lostluck lostluck commented Aug 3, 2023

Additional constants were changed to use prism as the default Runner for tests.

See #24789 and #27550


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #27832 (8bb1053) into master (1b76101) will decrease coverage by 0.01%.
Report is 25 commits behind head on master.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master   #27832      +/-   ##
==========================================
- Coverage   70.97%   70.97%   -0.01%     
==========================================
  Files         860      860              
  Lines      104862   104862              
==========================================
- Hits        74430    74422       -8     
- Misses      28873    28882       +9     
+ Partials     1559     1558       -1     
Flag Coverage Δ
go 53.71% <50.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
sdks/go/pkg/beam/testing/ptest/ptest.go 55.55% <50.00%> (ø)

... and 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @riteshghorse for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@riteshghorse riteshghorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lostluck lostluck merged commit ead1cef into apache:master Aug 3, 2023
5 of 6 checks passed
bvolpato pushed a commit to bvolpato/beam that referenced this pull request Aug 3, 2023
Co-authored-by: lostluck <13907733+lostluck@users.noreply.github.com>
BjornPrime pushed a commit to BjornPrime/my-beam that referenced this pull request Aug 7, 2023
Co-authored-by: lostluck <13907733+lostluck@users.noreply.github.com>
bullet03 pushed a commit to akvelon/beam that referenced this pull request Aug 11, 2023
Co-authored-by: lostluck <13907733+lostluck@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants