This repository has been archived by the owner on May 25, 2021. It is now read-only.
Add max_document_size checking for multipart PUT requests #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously multipart/related PUT requests didn't check maximum request sizes. This commit checks content-length and compares that with the maximum. This means keeping the current "semantics" of max_document_size which actually means "max request size". But this makes the check more efficient and can be done earlier in request processing time. Jira: COUCHDB-3174
nickva
added a commit
to cloudant/couchdb-chttpd
that referenced
this pull request
Oct 4, 2016
Previously multipart/related PUT requests didn't check maximum request sizes. This commit checks content-length and compares that with the maximum. This means keeping the current "semantics" of max_document_size which actually means "max request size". But this makes the check more efficient and can be done earlier in request processing time. PR depends on apache/couchdb-couch#201 make sure to merge that one first if accepted. Jira: COUCHDB-3174
|
+1 but we'll want to document the new behavior somewhere. Also, you don't need the Jira: in front of your COUCHDB-3174 in the commit message. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously multipart/related PUT requests didn't check maximum request sizes.
This commit checks content-length and compares that with the maximum.
This means keeping the current "semantics" of max_document_size which actually
means "max request size". But this makes the check more efficient and can
be done earlier in request processing time.
Jira: COUCHDB-3174