Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mango): plug hole in unit test coverage of view cursor functions #4763

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

pgj
Copy link
Contributor

@pgj pgj commented Sep 15, 2023

Add a missing eunit case for testing error handling of mango_cursor_view:handle_message/2. This was noticed while working on #4735, but I feel it is better to factor this piece out and submit in a separate (and dedicated) commit.

Testing recommendations

make eunit apps=mango

The coverage of mango_cursor_view should jump from 99% to 100%.

Copy link
Contributor

@nickva nickva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@pgj pgj merged commit c8521cb into apache:main Sep 15, 2023
14 checks passed
@pgj pgj deleted the fix/mango/view-cursor-coverage branch September 15, 2023 14:20
@pgj
Copy link
Contributor Author

pgj commented Sep 15, 2023

Thanks @nickva!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants