Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve stacktrace format and clean main.cc #1053

Merged
merged 4 commits into from
Oct 29, 2022
Merged

Improve stacktrace format and clean main.cc #1053

merged 4 commits into from
Oct 29, 2022

Conversation

PragmaTwice
Copy link
Member

@PragmaTwice PragmaTwice commented Oct 29, 2022 •
edited
Loading

  • Align function names in stacktrace (in segvHandler)
  • Remove many useless code

tisonkun
tisonkun reviewed Oct 29, 2022
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any description (what is to be implemented) of this change? It seems miscellaneous in one patch.

@PragmaTwice
Copy link
Member Author

Any description (what is to be implemented) of this change? It seems miscellaneous in one patch.

Added.

tisonkun
tisonkun reviewed Oct 29, 2022
View reviewed changes
src/main.cc Show resolved Hide resolved
@tisonkun tisonkun merged commit 8946859 into apache:unstable Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-hulk git-hulk git-hulk approved these changes

@tisonkun tisonkun tisonkun approved these changes

@ShooterIT ShooterIT Awaiting requested review from ShooterIT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PragmaTwice @git-hulk @tisonkun