Fix performance-unnecessary-value-param warning reported by clang-tidy

[tanruixiang]

This close #1105

[tanruixiang]

By the way, I'm curious if there are any automated tools to fix relatively simple check like this one. @PragmaTwice

[torwig]

@tanruixiang I think such code fixes aren't similar to formatting and are able to change program behavior, so probably it's better to fix them manually, double-checking every case. Even if, in 99.99% of cases, the 'auto-fix' will do the right thing.

[torwig]

LGTM

[PragmaTwice]

By the way, I'm curious if there are any automated tools to fix relatively simple check like this one. @PragmaTwice

Sure, some clang-tidy checks provide auto-fix, but it cannot guarantee 100% right for fixed code, so I recommand at least manual review these reports one by one.

BTW, if you configure your editor/IDE correctly (vim/vscode/emacs with clangd or clion), you should see a fix button in the pop-up window in every code segment where a report exists here (if the check provides auto-fix). Some of them may also provide a button to fix all reports in the current source file.

[tanruixiang]

BTW, if you configure your editor/IDE correctly (vim/vscode/emacs with clangd or clion), you should see a fix button in the pop-up window in every code segment where a report exists here. Some of them may also provide a button to fix all reports in the current source file.

Yes, vscode just need to download Clang-Tidy and take effect without any configuration.

[PragmaTwice]

Thanks all. Merging...