Fix SockConect doesn't resolve domain before connecting #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, Kvrocks supports connecting server with timeout or not, but the behavior is a bit different between them. The timeout version doesn't support resolving domain before connecting server, so it'll be broken if connects with timeout.
juancresc
previously approved these changes
Dec 16, 2022
PragmaTwice
reviewed
Dec 17, 2022
git-hulk
requested review from
PragmaTwice and
juancresc
and removed request for
juancresc
tisonkun
approved these changes
Dec 17, 2022
PragmaTwice
approved these changes
Dec 17, 2022
PragmaTwice
reviewed
Dec 17, 2022
| if (fcntl(*fd, F_SETFL, socket_arg) < 0) { | ||
| return Status::FromErrno(); | ||
| if (!s.IsOK()) { | ||
| continue; |
There was a problem hiding this comment.
continue or return error directly, which is better here?
There was a problem hiding this comment.
Looks better to continue if it has other addresses to have a try.
caipengbo
approved these changes
Dec 17, 2022
|
Thanks all, merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1182
Currently, Kvrocks supports connecting the server with timeout or not, but the behavior is a bit different between them. The timeout version doesn't support resolving the domain before connecting to the server, so it'll be broken if use it to connect the domain.
SockConnect with timeout is the first time to use in #1172, so this bug won't affect the previous releases.