Refactoring: check function return Status marked as [[nodiscard]] #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great changes. Since all warnings are fixed, could you modify the CMakeFiles to make the warning as error? You can just follow this TODO, and put |
|
@PragmaTwice Done. |
PragmaTwice
approved these changes
Jan 1, 2023
tisonkun
approved these changes
Jan 2, 2023
git-hulk
approved these changes
Jan 2, 2023
|
Thanks all. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all the return values of the
Statustype if they are marked as [[nodiscard]].Some functions were refactored so that now they return
Statusinstead ofboolorvoid; some functions now didn't returnStatus.Closes: #1196