-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to enable the async_io option to improve the performance #1215
Conversation
Cool, I think it'd be better if we have the option to let users determine whether to enable it or not. |
Since this option is marked as |
6538e2c
to
cadd755
Compare
@xiaobiaozhao It's not right to involve the server in the storage layer. You should add the async_io flag in storage or implement like the write option https://github.com/apache/incubator-kvrocks/blob/unstable/src/storage/storage.cc#L76 |
cadd755
to
ee859c3
Compare
Good feature, any updates? In latest rocksdb update fixed some bugs in async_io support, so this PR is very good point to improve our performance. |
dcf34a8
to
747c42e
Compare
@xiaobiaozhao has updated the PR, to see if @torwig and @PragmaTwice have comments. |
@xiaobiaozhao Good research. |
fe5038d
to
d96610b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks all, merging... |
Here are some comparisons between
async_io
andnormal
big value 500B
small value 50B
monitor diff
The green line is kvrocks compiled by async io,this pr.
ts*
command using seek function to scan data from db.summarize
async_io
is better in seek read, higher qps, lower latency, and slightly higher cpu usage. Perfect for introducing projects