Kvrocks2Redis: decode slot ID in cluster mode #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-hulk
approved these changes
Jan 11, 2023
caipengbo
reviewed
Jan 11, 2023
caipengbo
approved these changes
Jan 11, 2023
|
Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
Kvrocks2Redisdoesn't decode the slot ID if a cluster mode is enabled.For example, if we write to
Kvrocksin a cluster mode the following value:set book1 "Anything here"And run
Kvrocks2Rediswithcluster-enableset toyes, we will get inRedisthe following key:\x16\x9bbook1where
169bis a hex representation of slot 5787.The reason: the
Kvrocksconfig keyslot_id_encodedis not set. Setting only thecluster_enableconfig value is not enough forKvrocks2Redis. InKvrockswe have this.