Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some new-delete patterns and refine LockManager hash function #1268

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Remove some new-delete patterns and refine LockManager hash function #1268

merged 1 commit into from
Feb 20, 2023

Conversation

PragmaTwice
Copy link
Member

@PragmaTwice PragmaTwice commented Feb 20, 2023 •
edited
Loading

  • Use unique_ptr in LogCollector and LockManager
  • Use deque in LogCollector
  • Refine LockManager::hash to prevent string copy
  • Rewrite Server::cleanupExitedSlaves to remove unused std::list

torwig
torwig approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@torwig torwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PragmaTwice
Copy link
Member Author

Thanks all. Merging...

@PragmaTwice PragmaTwice merged commit a08a0ff into apache:unstable Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-hulk git-hulk git-hulk approved these changes

@torwig torwig torwig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PragmaTwice @git-hulk @torwig