Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use constexpr to simplify the getXXX method in EvbufCallbackBase #1443

Merged
merged 1 commit into from
May 19, 2023
Merged

Use constexpr to simplify the getXXX method in EvbufCallbackBase #1443

merged 1 commit into from
May 19, 2023

Conversation

ellutionist
Copy link
Contributor

No description provided.

@torwig
Copy link
Contributor

torwig commented May 18, 2023

@ellutionist Thank you, it looks really simpler. I'd like to hear @PragmaTwice, the template magician :)

PragmaTwice
PragmaTwice approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@PragmaTwice PragmaTwice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@git-hulk
Copy link
Member

Thanks all, I will merge and summary this PR change.

@git-hulk git-hulk changed the title Simplify EvbufCallbackBase Use constexpr to simplify the getXXX method in EvbufCallbackBase May 19, 2023
@git-hulk git-hulk merged commit 640d32e into apache:unstable May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torwig torwig torwig approved these changes

@PragmaTwice PragmaTwice PragmaTwice approved these changes

@xiaobiaozhao xiaobiaozhao xiaobiaozhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ellutionist @torwig @git-hulk @PragmaTwice @xiaobiaozhao