Use the rocksdb mget to improve the performance

[zevin02]

fixes: #1441

• Use RocksDB's MultiGet to improve mget performance of hash

[mapleFU]

The code LGTM.

By the way, should we add a Storage::MultiGet without ColumnFamily like Get?

[zevin02]

I think I can add it

[mapleFU]

Sorry, miss the NotFound part

[mapleFU]

@zevin02 Could you find or add a testcase for #1455 ?

[zevin02]

@zevin02 Could you find or add a testcase for #1455 ? @zevin02 你能为 #1455 找到或添加一个测试用例吗？

What does it mean? Do I need to add a test case for reproducing this issue? I think the PR I just modified already fixed this issue.

[git-hulk]

Sorry, miss the NotFound part

😊 No problem. Great thanks for your review.

[infdahai]

What does it mean? Do I need to add a test case for reproducing this issue? I think the PR I just modified already fixed this issue.

It means you can just write a test to record this process. (Add a test to the hash test)
https://github.com/apache/incubator-kvrocks/blob/fb0e3d42031a6e0691c7a736711d0a01d72bdb1a/tests/gocase/unit/type/hash/hash_test.go#L53

The test is just used to avoid this situation reproducing due to the code that follows.

[mapleFU]

--- FAIL: TestSlotMigrateSync (47.71s)
    --- FAIL: TestSlotMigrateSync/MIGRATE_-_Migrate_sync_with_(or_without)_all_kinds_of_timeouts (0.01s)
        slotmigrate_test.go:425: 
            	Error Trace:	/home/runner/work/incubator-kvrocks/incubator-kvrocks/tests/gocase/integration/slotmigrate/slotmigrate_test.go:425
            	Error:      	Not equal: 
            	            	expected: string("OK")
            	            	actual  : <nil>(<nil>)
            	Test:       	TestSlotMigrateSync/MIGRATE_-_Migrate_sync_with_(or_without)_all_kinds_of_timeouts
FAIL
exit status 1

Is the unittest failed related?

[zevin02]

--- FAIL: TestSlotMigrateSync (47.71s)
    --- FAIL: TestSlotMigrateSync/MIGRATE_-_Migrate_sync_with_(or_without)_all_kinds_of_timeouts (0.01s)
        slotmigrate_test.go:425: 
            	Error Trace:	/home/runner/work/incubator-kvrocks/incubator-kvrocks/tests/gocase/integration/slotmigrate/slotmigrate_test.go:425
            	Error:      	Not equal: 
            	            	expected: string("OK")
            	            	actual  : <nil>(<nil>)
            	Test:       	TestSlotMigrateSync/MIGRATE_-_Migrate_sync_with_(or_without)_all_kinds_of_timeouts
FAIL
exit status 1

Is the unittest failed related?

I did not make any changes to the relevant code and I don't know why there is an error.

[infdahai]

It is related to #1452.

[zevin02]

emm,So what should I do

It is related to #1452.

[infdahai]

Sometimes the test works and sometimes it doesn't. So just ignore it for now.

[mapleFU]

@zevin02 Patch LGTM. And the hash case is tested. Let's wait committer rerun the unittest tomorrow.

[zevin02]

What does it mean? Do I need to add a test case for reproducing this issue? I think the PR I just modified already fixed this issue.

It means you can just write a test to record this process. (Add a test to the hash test)

https://github.com/apache/incubator-kvrocks/blob/fb0e3d42031a6e0691c7a736711d0a01d72bdb1a/tests/gocase/unit/type/hash/hash_test.go#L53

The test is just used to avoid this situation reproducing due to the code that follows.

I can add this test case later

[git-hulk]

Thanks all, the patch looks good to be merged.