Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print error when occurring the flaky test in TestBitmap #1473

Merged
merged 1 commit into from
May 25, 2023

Conversation

infdahai
Copy link
Contributor

close: #1472

related issue: apache#1472

Signed-off-by: clundro <infdahai@outlook.com>
@torwig
Copy link
Contributor

torwig commented May 24, 2023

@infdahai Do you want to investigate the reason for an error by using 2/3 lines instead of one?

@infdahai
Copy link
Contributor Author

infdahai commented May 24, 2023

Yeah, we should distinguish between CI timeouts and program logic errors. Is there any brief way?

If there is no good one, we can wrap these calls.

@torwig
Copy link
Contributor

torwig commented May 24, 2023

Right now I don't know the other way so we can try this one.

Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@git-hulk git-hulk changed the title Fix flaky test in TestBitmap Print error when occurring the flaky test in TestBitmap May 25, 2023
@git-hulk git-hulk merged commit 4ac1423 into apache:unstable May 25, 2023
@infdahai infdahai deleted the bit_test branch May 25, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test TestBitmap
3 participants