Fix GEOHASH / GEOPOS should return nil array instead of error for non-existing key #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… key The current code GETHASH returns an error for a key that doesn't exist: ``` 127.0.0.1:6666> geohash mykey a b c (error) ERR NotFound: ``` In Redis this would return: ``` 127.0.0.1:6379> geohash mykey a b c 1) (nil) 2) (nil) 3) (nil) ``` This PR fixes the inconsistency in this case.
enjoy-binbin
changed the title
git-hulk
approved these changes
Jul 11, 2023
git-hulk
pushed a commit
to git-hulk/kvrocks
that referenced
this pull request
Jul 30, 2023
…-existing key (apache#1573) The current code GETHASH returns an error for a key that doesn't exist: ``` 127.0.0.1:6666> geohash mykey a b c (error) ERR NotFound: ``` In Redis, this would return: ``` 127.0.0.1:6379> geohash mykey a b c 1) (nil) 2) (nil) 3) (nil) ``` GEOPOS also has the same issue, this PR fixes these inconsistencies in this case.
git-hulk
pushed a commit
that referenced
this pull request
Aug 1, 2023
…-existing key (#1573) The current code GETHASH returns an error for a key that doesn't exist: ``` 127.0.0.1:6666> geohash mykey a b c (error) ERR NotFound: ``` In Redis, this would return: ``` 127.0.0.1:6379> geohash mykey a b c 1) (nil) 2) (nil) 3) (nil) ``` GEOPOS also has the same issue, this PR fixes these inconsistencies in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code GETHASH returns an error for a key
that doesn't exist:
In Redis this would return:
GEOPOS alos have the same issue, this PR fixes these
inconsistency in this case.