ZRANGE / ZREVRANK add withscore option support #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an option "withscores" to ZRANK and ZREVRANK. The syntax are: ``` zrank key member [WITHSCORE] zrevrank key member [WITHSCORE] ``` With this option, will additionally return the member's score, in the form of an array. ``` 127.0.0.1:6666> zadd zset 1 a 2 b 3 c (integer) 3 127.0.0.1:6666> zrank zset b withscore 1) (integer) 1 2) "2" 127.0.0.1:6666> zrevrank zset c withscore 1) (integer) 0 2) "3" ``` This option was added in Redis 7.2
mapleFU
reviewed
Jul 25, 2023
mapleFU
approved these changes
Jul 25, 2023
| EXPECT_EQ(i, static_cast<int>(fields_.size() - rank - 1)); | ||
| EXPECT_EQ(scores_[i], score); |
There was a problem hiding this comment.
Would FLOAT EQ better here? Or it's expect to be EQ?
p1u3o
pushed a commit
to p1u3o/incubator-kvrocks
that referenced
this pull request
Aug 1, 2023
Add an option "withscores" to ZRANK and ZREVRANK. The syntax are: ``` zrank key member [WITHSCORE] zrevrank key member [WITHSCORE] ``` With this option, will additionally return the member's score, in the form of an array. ``` 127.0.0.1:6666> zadd zset 1 a 2 b 3 c (integer) 3 127.0.0.1:6666> zrank zset b withscore 1) (integer) 1 2) "2" 127.0.0.1:6666> zrevrank zset c withscore 1) (integer) 0 2) "3" ``` This option was added in Redis 7.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option "withscores" to ZRANK and ZREVRANK.
The syntax are:
With this option, will additionally return the member's score,
in the form of an array.
This option was added in Redis 7.2