Fix GEOSEARCH/GEOSEARCHSTORE FROMMEMBER against non existing src key reply #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reply The new GEOSEARCH and GEOSEARCHSTORE commands was added in apache#1533. When typing FROMMEMBER option against non-existing src key, an IsNotFound error is return and resulting in the following inconsistency: ``` 127.0.0.1:6666> GEOSEARCH src FROMMEMBER Shenzhen BYBOX 88 88 m (error) ERR NotFound: 127.0.0.1:6666> GEOSEARCHSTORE dst src FROMMEMBER Shenzhen BYBOX 88 88 m (error) ERR NotFound: 127.0.0.1:6379> GEOSEARCH src FROMMEMBER Shenzhen BYBOX 88 88 m (empty array) 127.0.0.1:6379> GEOSEARCHSTORE dst src FROMMEMBER Shenzhen BYBOX 88 88 m (integer) 0 ```
torwig
previously approved these changes
Jul 31, 2023
mapleFU
previously approved these changes
Jul 31, 2023
i haven't looked at the store section below yet, just a quick look, looks like it doesn't need it. |
git-hulk
approved these changes
Jul 31, 2023
torwig
approved these changes
Jul 31, 2023
PragmaTwice
approved these changes
Jul 31, 2023
p1u3o
pushed a commit
to p1u3o/incubator-kvrocks
that referenced
this pull request
Aug 1, 2023
…reply (apache#1625) The new GEOSEARCH and GEOSEARCHSTORE commands were added in apache#1533. When typing the FROMMEMBER option against non-existing src key, an IsNotFound error is returned and resulting in the following inconsistency: ``` 127.0.0.1:6666> GEOSEARCH src FROMMEMBER Shenzhen BYBOX 88 88 m (error) ERR NotFound: 127.0.0.1:6666> GEOSEARCHSTORE dst src FROMMEMBER Shenzhen BYBOX 88 88 m (error) ERR NotFound: 127.0.0.1:6379> GEOSEARCH src FROMMEMBER Shenzhen BYBOX 88 88 m (empty array) 127.0.0.1:6379> GEOSEARCHSTORE dst src FROMMEMBER Shenzhen BYBOX 88 88 m (integer) 0 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new GEOSEARCH and GEOSEARCHSTORE commands was added
in #1533. When typing FROMMEMBER option against non-existing
src key, an IsNotFound error is return and resulting in the
following inconsistency: