MSET change it to batch write instead of batch per key #1634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation which wrote the batch per key, we should change it to a single batch.
git-hulk
previously approved these changes
Aug 4, 2023
mapleFU
reviewed
Aug 4, 2023
git-hulk
reviewed
Aug 5, 2023
git-hulk
previously approved these changes
Aug 6, 2023
xiaobiaozhao
previously approved these changes
Aug 6, 2023
enjoy-binbin
dismissed stale reviews from xiaobiaozhao and git-hulk
via
3669db6
Co-authored-by: mwish <1506118561@qq.com>
mapleFU
approved these changes
Aug 7, 2023
git-hulk
approved these changes
Aug 7, 2023
p1u3o
pushed a commit
to p1u3o/incubator-kvrocks
that referenced
this pull request
Aug 15, 2023
The previous implementation which wrote the batch per key, we should change it to a single batch. Also use the multi-key lock before the write operations instead of inside the loop. This is mention in apache#1631, found by hulk. Co-authored-by: mwish <1506118561@qq.com>
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation which wrote the batch per key,
we should change it to a single batch. Also use the multi-key
lock before the write operations instead of inside the loop.
This is mention in #1631, found by hulk.