Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no binary directory error of xxhash in CMake #1779

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Fix no binary directory error of xxhash in CMake #1779

merged 2 commits into from
Sep 26, 2023

Conversation

PragmaTwice
Copy link
Member

@PragmaTwice PragmaTwice commented Sep 25, 2023 •
edited
Loading

Close #1778 .

xxhash_BINARY_DIR is the right variable instead of xxhash_BUILD_DIR.

enjoy-binbin
enjoy-binbin approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@enjoy-binbin enjoy-binbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this is something like a typo error? (or other)
anyway, can you also update the top commen to mention the reason (and fix)? thanks.

@PragmaTwice
Copy link
Member Author

so this is something like a typo error? (or other) anyway, can you also update the top commen to mention the reason (and fix)? thanks.

Yeah, it is a typo.

@enjoy-binbin enjoy-binbin merged commit 493c6d0 into apache:unstable Sep 26, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-hulk git-hulk git-hulk approved these changes

@torwig torwig torwig approved these changes

@enjoy-binbin enjoy-binbin enjoy-binbin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMake error during the build on Fedora 38
4 participants
@PragmaTwice @git-hulk @torwig @enjoy-binbin