Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch up for json-set with multiple values #1827

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

mapleFU
Copy link
Member

@mapleFU mapleFU commented Oct 15, 2023

JSON.SET might match the path for multiple values. This patch remove the move for that

@mapleFU
Copy link
Member Author

mapleFU commented Oct 15, 2023

--- FAIL: TestRedisCli (14.14s)
    --- FAIL: TestRedisCli/test_interactive_cli (0.01s)
        --- FAIL: TestRedisCli/test_interactive_cli/Status_reply (0.00s)
            cli_test.go:111: 
                	Error Trace:	/__w/kvrocks/kvrocks/tests/gocase/integration/cli/cli_test.go:111
                	            				/__w/kvrocks/kvrocks/tests/gocase/integration/cli/cli_test.go:174
                	Error:      	Not equal: 
                	            	expected: "OK"
                	            	actual  : "get_per_sec:0\nseek_per_sec:0\nnext_per_sec:0\nprev_per_sec:0\nis_bgsaving:no\nis_compacting:no"
                	            	
                	            	Diff:
                	            	--- Expected
                	            	+++ Actual
                	            	@@ -1 +1,6 @@
                	            	-OK
                	            	+get_per_sec:0
                	            	+seek_per_sec:0
                	            	+next_per_sec:0
                	            	+prev_per_sec:0
                	            	+is_bgsaving:no
                	            	+is_compacting:no
                	Test:       	TestRedisCli/test_interactive_cli/Status_reply
        --- FAIL: TestRedisCli/test_interactive_cli/Integer_reply (0.00s)
            cli_test.go:111: 
                	Error Trace:	/__w/kvrocks/kvrocks/tests/gocase/integration/cli/cli_test.go:111
                	            				/__w/kvrocks/kvrocks/tests/gocase/integration/cli/cli_test.go:178
                	Error:      	Not equal: 
                	            	expected: "(integer) 1"
                	            	actual  : "OK"
                	            	
                	            	Diff:
                	            	--- Expected
                	            	+++ Actual
                	            	@@ -1 +1 @@
                	            	-(integer) 1
                	            	+OK
                	Test:       	TestRedisCli/test_interactive_cli/Integer_reply
        --- FAIL: TestRedisCli/test_interactive_cli/Bulk_reply (0.00s)
            cli_test.go:111: 
                	Error Trace:	/__w/kvrocks/kvrocks/tests/gocase/integration/cli/cli_test.go:111
                	            				/__w/kvrocks/kvrocks/tests/gocase/integration/cli/cli_test.go:183
                	Error:      	Not equal: 
                	            	expected: "\"foo\""
                	            	actual  : "(integer) 1"
                	            	
                	            	Diff:
                	            	--- Expected
                	            	+++ Actual
                	            	@@ -1 +1 @@
                	            	-"foo"
                	            	+(integer) 1
                	Test:       	TestRedisCli/test_interactive_cli/Bulk_reply
        --- FAIL: TestRedisCli/test_interactive_cli/Multi-bulk_reply (0.00s)
            cli_test.go:111: 
                	Error Trace:	/__w/kvrocks/kvrocks/tests/gocase/integration/cli/cli_test.go:111
                	            				/__w/kvrocks/kvrocks/tests/gocase/integration/cli/cli_test.go:189
                	Error:      	Not equal: 
                	            	expected: "1) \"foo\"\n2) \"bar\""
                	            	actual  : "\"foo\""
                	            	
                	            	Diff:
                	            	--- Expected
                	            	+++ Actual
                	            	@@ -1,2 +1 @@
                	            	-1) "foo"
                	            	-2) "bar"
                	            	+"foo"
                	Test:       	TestRedisCli/test_interactive_cli/Multi-bulk_reply
        --- FAIL: TestRedisCli/test_interactive_cli/Parsing_quotes (0.00s)
            cli_test.go:111: 
                	Error Trace:	/__w/kvrocks/kvrocks/tests/gocase/integration/cli/cli_test.go:111
                	            				/__w/kvrocks/kvrocks/tests/gocase/integration/cli/cli_test.go:196
                	Error:      	Not equal: 
                	            	expected: "OK"
                	            	actual  : "1) \"foo\"\n2) \"bar\""
                	            	
                	            	Diff:
                	            	--- Expected
                	            	+++ Actual
                	            	@@ -1 +1,2 @@
                	            	-OK
                	            	+1) "foo"
                	            	+2) "bar"
                	Test:       	TestRedisCli/test_interactive_cli/Parsing_quotes
FAIL
exit status 1

Hmm does this happen before?

@git-hulk
Copy link
Member

Hmm does this happen before?

Yes, it's a known flaky test but didn't investigate the reason yet.

@mapleFU mapleFU merged commit 4d88a09 into apache:unstable Oct 16, 2023
28 checks passed
@mapleFU mapleFU deleted the catch-up-json-set branch October 16, 2023 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants