Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for the JSON.CLEAR command #1850

Merged
merged 9 commits into from
Oct 24, 2023
Merged

Support for the JSON.CLEAR command #1850

merged 9 commits into from
Oct 24, 2023

Conversation

2rueSid
Copy link
Contributor

@2rueSid 2rueSid commented Oct 22, 2023 •
edited by git-hulk
Loading

support JSON.CLEAR, this closes #1812
please review @mapleFU

JSON.CLEAR command

@torwig
Copy link
Contributor

torwig commented Oct 22, 2023

@2rueSid You can format your code with the ./x.py command. It allows your code to pass the lint stage in the CI pipeline.

git-hulk
git-hulk reviewed Oct 23, 2023
View reviewed changes
kvrocks.conf Outdated Show resolved Hide resolved
src/common/status.h Outdated Show resolved Hide resolved
@git-hulk
Copy link
Member

Rest are good to me, great work! @2rueSid

mapleFU
mapleFU reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@mapleFU mapleFU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM except some style problems!
Thanks!

src/common/status.h Outdated Show resolved Hide resolved
@PragmaTwice PragmaTwice changed the title Support for the json clear command Support for the JSON.CLEAR command Oct 23, 2023
PragmaTwice
PragmaTwice reviewed Oct 23, 2023
View reviewed changes
src/types/json.h Outdated Show resolved Hide resolved
@2rueSid 2rueSid force-pushed the support_for_the_json_clear_command branch from 347dd17 to 5b4a7b3 Compare October 23, 2023 16:29
torwig
torwig approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@torwig torwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, LGTM.

mapleFU
mapleFU approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@mapleFU mapleFU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will wait for twice's review

@PragmaTwice PragmaTwice merged commit 35e041f into apache:unstable Oct 24, 2023
28 checks passed
@PragmaTwice
Copy link
Member

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-hulk git-hulk git-hulk approved these changes

@torwig torwig torwig approved these changes

@PragmaTwice PragmaTwice PragmaTwice approved these changes

@mapleFU mapleFU mapleFU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for the JSON.CLEAR command
5 participants
@2rueSid @torwig @git-hulk @PragmaTwice @mapleFU