Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the support of RESP3 double type #2053

Merged
merged 4 commits into from
Jan 26, 2024
Merged

Add the support of RESP3 double type #2053

merged 4 commits into from
Jan 26, 2024

Conversation

git-hulk
Copy link
Member

This closes #1995

torwig
torwig reviewed Jan 25, 2024
View reviewed changes
src/commands/cmd_hash.cc Show resolved Hide resolved
src/commands/cmd_zset.cc Show resolved Hide resolved
jihuayu
jihuayu reviewed Jan 25, 2024
View reviewed changes
Copy link
Member

@jihuayu jihuayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Only a little typo, Others is LGTM.

src/commands/cmd_zset.cc Outdated Show resolved Hide resolved
@git-hulk
Copy link
Member Author

@jihuayu @torwig Thanks for your good reviews. All are done, plz take a look again.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 26, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
60.7% Coverage on New Code
1.4% Duplication on New Code

See analysis details on SonarCloud

@git-hulk git-hulk merged commit 3ea7f4f into apache:unstable Jan 26, 2024
30 checks passed
@git-hulk git-hulk mentioned this pull request Mar 4, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caipengbo caipengbo caipengbo approved these changes

@jihuayu jihuayu jihuayu approved these changes

@PragmaTwice PragmaTwice Awaiting requested review from PragmaTwice

@torwig torwig Awaiting requested review from torwig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add RESP3 double type
4 participants
@git-hulk @torwig @caipengbo @jihuayu