Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of the command JSON.MSET #2228

Merged
merged 10 commits into from
Apr 8, 2024
Merged

Add support of the command JSON.MSET #2228

merged 10 commits into from
Apr 8, 2024

Conversation

zjregee
Copy link
Member

@zjregee zjregee commented Apr 7, 2024

fix: #1817

zjregee
zjregee commented Apr 7, 2024
View reviewed changes
src/types/redis_json.h Outdated Show resolved Hide resolved
git-hulk
git-hulk previously approved these changes Apr 7, 2024
View reviewed changes
PragmaTwice
PragmaTwice previously approved these changes Apr 7, 2024
View reviewed changes
@zjregee zjregee dismissed stale reviews from PragmaTwice and git-hulk via 20eacd1 April 7, 2024 13:00
@zjregee
Copy link
Member Author

zjregee commented Apr 7, 2024

There is a docker build error and a kvrocks compilation error in CI, I'm not sure if this is a bug introduced by PR and if I need to modify something because of it.

@jihuayu
Copy link
Member

jihuayu commented Apr 7, 2024

@zjregee It seems like CI is OK now.

jihuayu
jihuayu reviewed Apr 7, 2024
View reviewed changes
Copy link
Member

@jihuayu jihuayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you change some code to make Snorcloud happy?

src/commands/cmd_json.cc Outdated Show resolved Hide resolved
src/types/redis_json.cc Outdated Show resolved Hide resolved
@git-hulk git-hulk changed the title feat: add json.mset command Add support of the command JSON.MSET Apr 8, 2024
git-hulk
git-hulk previously approved these changes Apr 8, 2024
View reviewed changes
jihuayu
jihuayu previously approved these changes Apr 8, 2024
View reviewed changes
mapleFU
mapleFU reviewed Apr 8, 2024
View reviewed changes
src/types/redis_json.cc Outdated Show resolved Hide resolved
src/types/redis_json.cc Outdated Show resolved Hide resolved
@zjregee zjregee dismissed stale reviews from jihuayu and git-hulk via 2264ebe April 8, 2024 10:41
@mapleFU mapleFU merged commit 0638c46 into apache:unstable Apr 8, 2024
30 checks passed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 8, 2024

Quality Gate Passed Quality Gate passed

Issues
28 New issues
0 Accepted issues

Measures
0 Security Hotspots
52.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@zjregee zjregee deleted the add-json.mset-command branch April 8, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-hulk git-hulk git-hulk approved these changes

@mapleFU mapleFU mapleFU approved these changes

@jihuayu jihuayu jihuayu approved these changes

@PragmaTwice PragmaTwice Awaiting requested review from PragmaTwice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for the JSON.MSET command
5 participants
@zjregee @jihuayu @git-hulk @PragmaTwice @mapleFU