Fix compiler warnings in KQIR and RDB #2303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapleFU
reviewed
May 8, 2024
Comment on lines
103
to
105
| default: | ||
| assert(false); | ||
| return false; |
There was a problem hiding this comment.
Should we elaborate all branches rather than a unreachable "default"
There was a problem hiding this comment.
Actually all branches are covered here, but gcc thought it should have a default branch to cover any unforeseen case.
PragmaTwice
reviewed
May 8, 2024
PragmaTwice
changed the title
PragmaTwice
approved these changes
May 9, 2024
git-hulk
approved these changes
May 10, 2024
|
The CI failure is not related to this PR, will take a look later. |
PragmaTwice
approved these changes
May 11, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to gcc output, fix two compiler warnings.