Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging message for retryable background IO errors #2317

Merged
merged 7 commits into from
May 17, 2024

Conversation

VasuDevrani
Copy link
Contributor

@VasuDevrani VasuDevrani commented May 16, 2024

This closes #2312

@git-hulk git-hulk changed the title Improve logging message for retryableIOErrors Improve logging message for retryable background IO errors May 16, 2024
git-hulk
git-hulk previously approved these changes May 16, 2024
src/server/server.cc Outdated Show resolved Hide resolved
Co-authored-by: Twice <twice@apache.org>
mapleFU
mapleFU previously approved these changes May 16, 2024
caipengbo
caipengbo previously approved these changes May 16, 2024
src/server/server.cc Outdated Show resolved Hide resolved
src/server/server.cc Outdated Show resolved Hide resolved
Co-authored-by: Myth <caipengbo@outlook.com>
@PragmaTwice PragmaTwice dismissed stale reviews from caipengbo and mapleFU via c695aa5 May 16, 2024 14:28
PragmaTwice
PragmaTwice previously approved these changes May 16, 2024
Co-authored-by: Myth <caipengbo@outlook.com>
PragmaTwice
PragmaTwice previously approved these changes May 16, 2024
src/server/server.cc Outdated Show resolved Hide resolved
src/server/server.cc Outdated Show resolved Hide resolved
caipengbo
caipengbo previously approved these changes May 16, 2024
src/server/server.cc Outdated Show resolved Hide resolved
Copy link
Member

@PragmaTwice PragmaTwice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above.

Co-authored-by: Twice <twice@apache.org>
Copy link

sonarcloud bot commented May 17, 2024

@PragmaTwice PragmaTwice merged commit 15d81f0 into apache:unstable May 17, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error handling and logging for Retryable IO Errors
5 participants