fix(config): avoid rewriting the config file if it's unnecessary #2347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-hulk
commented
Jun 1, 2024
git-hulk
force-pushed
the
avoid-unnessary-config-rewrite
branch
from
26ac817
to
d6666f1
Compare
The server start will rewrite the config file to presist namespace/token pairs if the namespace replication is enabled. But it's unnecessary if the namespace replication is diabled or no tokens were loaded from the configuration file, because the purpose of this rewrite is to remove tokens from the config file and write to the Database.
git-hulk
force-pushed
the
avoid-unnessary-config-rewrite
branch
from
d6666f1
to
d4404a2
Compare
|
It can fix the problem when there's no namespace in kvrocks except the default one. But what if there are some namespaces? We also need to consider this situation. |
PragmaTwice
reviewed
Jun 1, 2024
|
PragmaTwice
previously approved these changes
Jun 1, 2024
git-hulk
force-pushed
the
avoid-unnessary-config-rewrite
branch
from
c62ab5d
to
7c584a1
Compare
PragmaTwice
approved these changes
Jun 1, 2024
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server start will rewrite the config file to persist namespace/token pairs
if the namespace replication is enabled. But it's unnecessary if the namespace replication
is disabled or no tokens were loaded from the configuration file because the purpose of
this rewrite is to remove tokens from the config file and write to the Database.