Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support unlink command #517

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Support unlink command #517

merged 1 commit into from
Mar 11, 2022

Conversation

ColinChamber
Copy link
Contributor

This is to avoid errors when users use redis unlink. It's a bit tricky, but RocksDB also frees space asynchronously.

git-hulk
git-hulk approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,cool.

@ShooterIT ShooterIT changed the title Fix unlink unknown Support unlink command Mar 11, 2022
ShooterIT
ShooterIT approved these changes Mar 11, 2022
View reviewed changes
Copy link
Member

@ShooterIT ShooterIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i also wanted to support it, but i don't know why i forgot 😂

@ShooterIT ShooterIT merged commit e3da57d into apache:unstable Mar 11, 2022
@ShooterIT ShooterIT added feature type new feature release notes labels Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-hulk git-hulk git-hulk approved these changes

@ShooterIT ShooterIT ShooterIT approved these changes

Assignees
No one assigned
Labels
feature type new feature release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ColinChamber @git-hulk @ShooterIT