Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rocksdb cmake depends should use list instead of string #518

Merged
merged 2 commits into from
Mar 12, 2022
Merged

Fix rocksdb cmake depends should use list instead of string #518

merged 2 commits into from
Mar 12, 2022

Conversation

git-hulk
Copy link
Member

@git-hulk git-hulk commented Mar 11, 2022

Kvrocks would throw below errors on debian 11 when building:

CMake Error at /usr/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:165 (message):
  Could NOT find JeMalloc (missing: JeMalloc_LIBRARIES JeMalloc_INCLUDE_DIRS)
Call Stack (most recent call first):
  /usr/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:458 (_FPHSA_FAILURE_MESSAGE)
  cmake/modules/FindJeMalloc.cmake:17 (find_package_handle_standard_args)
  CMakeLists.txt:103 (find_package)

It's caused by the wrong type of rocksdb_DEPENDS.

@git-hulk git-hulk requested a review from ShooterIT March 11, 2022 16:19
@git-hulk git-hulk added the bug type bug label Mar 11, 2022
@git-hulk git-hulk merged commit 378704c into apache:unstable Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug type bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants