-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LMove command #577
Add LMove command #577
Conversation
- LMove is able to operate on a single list if the source and destination are the same - In case of two lists LMove acquires two locks and performs Pop and Push atomically
Thanks @torwig. No worry, I can add test cases before merging. |
@git-hulk Could you please explain a little, why did the job |
@torwig Yes, the failure was NOT related with this PR. The root cause some test cases would fail occasionally when the CI environment become slowly. We have expected to find out those and fix them. |
@git-hulk Thank you. I merged your commit into my branch. |
OK, thanks. Will have a look soon. |
Good unit test coverage, thanks @torwig 👍 |
Different key names don't guarantee different indexes in mutex pool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, i ever wanted to add multi lock, but no action, thanks
one problem i need to confirm is that this command may not adapt slot migration, we should handle it in cc @ChrisZMF |
@ShooterIT Do you think is it a good idea to separate commands between Kvrocks and Kvrocks2Redis? Or we can do this in the next PR. |
fine, let's complete in the next PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for impressive work @torwig
I wrote only unit tests because I'm not currently familiar with TCL.