x.py: support source packaging #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tisonkun
commented
Jul 14, 2022
| f.write(version) | ||
|
|
||
| # 1. Git commit and tag | ||
| git = find_command('git', msg='git is required for source packaging') |
There was a problem hiding this comment.
We don't push anything to remote here. The release manager should manually git push --tags to push the tag.
In my opinion the workflow should be:
- Checkout a staging branch - if we do lightweight release, it's possible to run on
unstablebranch. - Run
./x.py package sourceto get the source tarball,.ascsign file,.sha512checksum file. - Copy those files to SVN (https://dist.apache.org/repos/dist/dev/incubator/kvrocks).
- Manually push tags (maybe we can have a
-rcNtailer, but I don't make it too complex now. - Calling a vote.
tisonkun
commented
Jul 14, 2022
|
|
||
| # 3. GPG Sign | ||
| gpg = find_command('gpg', msg='gpg is required for source packaging') | ||
| run([gpg, '--detach-sign', '--armor', tarball], stdout=subprocess.PIPE) |
There was a problem hiding this comment.
FYI - You can verify signature by gpg --verify ${tarball}.asc ${tarball}.
tisonkun
commented
Jul 14, 2022
Comment on lines
+158
to
+162
| sha512sum = find_command('sha512sum', msg='sha512sum is required for source packaging') | ||
| output = run([sha512sum, tarball], stdout=subprocess.PIPE) | ||
| payload = output.read().decode().strip() | ||
| with open(f'{tarball}.sha512', 'w+') as f: | ||
| f.write(payload) |
There was a problem hiding this comment.
FYI - You can verify checksum by sha512sum -c ${tarball}.sha512.
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
force-pushed
the
source-packaging
branch
from
71b0c9c
to
9d13b84
Compare
git-hulk
approved these changes
Jul 15, 2022
|
Thanks @tisonkun |
PragmaTwice
approved these changes
Jul 15, 2022
|
Thanks for your reviews. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try out with:
./x.py package source -v 2.1.0in a staging branch.