Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate sanitizer flags to all cmake deps #759

Merged
merged 14 commits into from
Jul 31, 2022
Merged

Propagate sanitizer flags to all cmake deps #759

merged 14 commits into from
Jul 31, 2022

Conversation

PragmaTwice
Copy link
Member

@PragmaTwice
Copy link
Member Author 

*** [err]: requests on cluster are ok in tests/integration/cluster.tcl
Expected '16383' to be equal to '' (context: type source line 257 file /Users/runner/work/incubator-kvrocks/incubator-kvrocks/tests/tcl/tests/integration/cluster.tcl cmd {assert_equal "16383" [$r3 get $slot_16383_key]} proc ::test)

from https://github.com/apache/incubator-kvrocks/runs/7536793002?check_suite_focus=true

@PragmaTwice
Copy link
Member Author

PragmaTwice commented Jul 30, 2022 •
edited
Loading

Hello everyone, any thought on this PR? ❤️

git-hulk
git-hulk approved these changes Jul 31, 2022
View reviewed changes
Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@PragmaTwice
Copy link
Member Author

Thanks all! Merging...

@PragmaTwice PragmaTwice merged commit 341a989 into apache:unstable Jul 31, 2022
@PragmaTwice PragmaTwice mentioned this pull request Jul 31, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-hulk git-hulk git-hulk approved these changes

@tisonkun tisonkun tisonkun approved these changes

@ShooterIT ShooterIT Awaiting requested review from ShooterIT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PragmaTwice @git-hulk @tisonkun