If unix socket is specified, don't listen default TCP if addr:port wasn't set #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sn't explicitly set
torwig
force-pushed
the
dont_listen_tcp_if_not_specified
branch
from
acbffb6
to
aaffc1e
Compare
|
Awesome, @torwig, lot of thanks! Please, review @PragmaTwice @ShooterIT @git-hulk |
PragmaTwice
reviewed
Sep 5, 2022
PragmaTwice
reviewed
Sep 5, 2022
git-hulk
reviewed
Sep 5, 2022
Co-authored-by: hulk <hulk.website@gmail.com>
git-hulk
approved these changes
Sep 5, 2022
ShooterIT
approved these changes
Sep 6, 2022
PragmaTwice
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows Kvrocks to listen to only the Unix socket
Close: #805