Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix server cannot exit properly when enabling cluster mode #969

Merged
merged 6 commits into from
Oct 11, 2022
Merged

Fix server cannot exit properly when enabling cluster mode #969

merged 6 commits into from
Oct 11, 2022

Conversation

git-hulk
Copy link
Member

This closes #965

@git-hulk
Copy link
Member Author

Can review commits one by one, this PR also solves some typos and naming issue.

tisonkun
tisonkun previously approved these changes Oct 11, 2022
View reviewed changes
caipengbo
caipengbo reviewed Oct 11, 2022
View reviewed changes
src/slot_migrate.h Outdated Show resolved Hide resolved
@git-hulk
Copy link
Member Author

Thanks all, merging...

@git-hulk git-hulk merged commit d33ef02 into apache:unstable Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caipengbo caipengbo caipengbo approved these changes

@PragmaTwice PragmaTwice PragmaTwice approved these changes

@ChrisZMF ChrisZMF Awaiting requested review from ChrisZMF

@ShooterIT ShooterIT Awaiting requested review from ShooterIT

@tisonkun tisonkun Awaiting requested review from tisonkun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The server cannot exit properly when enabling cluster mode
4 participants
@git-hulk @tisonkun @caipengbo @PragmaTwice