Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MCLEAN-116] Use default Log interface #37

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

Bukama
Copy link
Contributor

@Bukama Bukama commented Jan 14, 2024

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MCLEAN-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MCLEAN-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.


Provided commit message for squashing

[MCLEAN-116] Use default Log interface
Submitted by: Matthias Bünger

The logging interface of the Cleaner class was not able to log exceptions in a suitable way.
So it was replaced by the default logging interface provided by the AbstractMojo class.

As the AbstractMojo always returns a log instance (therefore never null) the null checks were removed and the same Systemlogger was used in the tests.

As changes are more than 20 lines I will file the icla later the day.

@Bukama
Copy link
Contributor Author

Bukama commented Jan 14, 2024

Additional note aside the commit message: Spotless reformatted a lot in the Cleaner file

@slawekjaranowski slawekjaranowski self-assigned this Mar 17, 2024
@slawekjaranowski slawekjaranowski merged commit 1e87ea3 into apache:master Apr 4, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants