Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MENFORCER-431] Introduce option to skip specific rules via custom property #205

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

psiroky
Copy link
Contributor

@psiroky psiroky commented Dec 27, 2022

I am creating this draft PR to discuss couple of points. This is not yet ready to merge. See the inline comments.

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MENFORCER-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MENFORCER-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

# specific language governing permissions and limitations
# under the License.

invoker.goals = validate -Denforcer.skipRules=alwaysFail
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • please add verify script yo be sure that rule alwaysPass was executed

@slawekjaranowski
Copy link
Member

@psiroky please look at #207 - it can impact on your code

@psiroky
Copy link
Contributor Author

psiroky commented Dec 28, 2022

@slawekjaranowski thanks for the heads-up. That seems to change things quite a bit, so I will probably wait until it gets merged and then re-do my changes on top of that.

@slawekjaranowski
Copy link
Member

@psiroky #207 - merged
Please look.

I will have next changes, so wait for you.

@psiroky psiroky changed the title [MENFORCER-431] Introduce property to skip specific rules [MENFORCER-431] Introduce option to skip specific rules via custom property Dec 29, 2022
@psiroky psiroky marked this pull request as ready for review December 29, 2022 11:25
@psiroky
Copy link
Contributor Author

psiroky commented Dec 29, 2022

@slawekjaranowski I believe this should be now ready for review. Please take another look when you get a chance.

@slawekjaranowski slawekjaranowski merged commit ef6eda3 into apache:master Dec 29, 2022
@psiroky psiroky deleted the MENFORCER-431 branch December 29, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants